Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace --show-logo with --no-art #1002

Merged
merged 1 commit into from
Apr 2, 2023
Merged

replace --show-logo with --no-art #1002

merged 1 commit into from
Apr 2, 2023

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Apr 2, 2023

Given the recent addition of #983, perhaps we could simplify the --show-logo option into a more straightforward Boolean flag, such as --no-art.

VISUALS:
      --no-color-palette  Hides the color palette
      --no-art            Hides the ascii art or image if provided

@o2sh o2sh requested a review from spenserblack as a code owner April 2, 2023 11:28
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense to me! --no-foo flags are pretty common.
If we implement a config, though, it might be good to having an accompanying --art flag, so the usage would be [--no-]art. Just that, whenever there's a config option, there's usually also an off and on flag. E.g. git commit [--no-]gpg-sign. I wonder if this is a clap builtin 🤔

@o2sh o2sh merged commit 20f4390 into main Apr 2, 2023
@o2sh o2sh deleted the feat/replace-show-logo branch April 2, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants