Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a test for negative dates and see how onefetch handles it #1100

Merged
merged 4 commits into from Jul 1, 2023
Merged

add a test for negative dates and see how onefetch handles it #1100

merged 4 commits into from Jul 1, 2023

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Jun 29, 2023

Currently there is an 'empty' error which probably is related to a failure to parse commits with negative dates.

This should be fixed in future versions of gitoxide.

@Byron Byron marked this pull request as draft June 29, 2023 07:09
@Byron
add a test for negative dates and see how onefetch handles it.
7a77046 
Currently there is an 'empty' error which probably is related to
a failure to parse commits with negative dates.

This should be fixed in future versions of `gitoxide`.
@Byron Byron changed the title add a test for negative dates and see how onefetch handles it. add a test for negative dates and see how onefetch handles it Jun 29, 2023
@Byron
feat: support repositories with dates prior to UNIX epoch.
c689f32 
Note that such repositories aren't easy to create in the first place
and such pre-dated commits need to be created with tool-assistance.

In any case, now `onefetch` is able to handle these as well.
@Byron Byron marked this pull request as ready for review June 29, 2023 11:06
@Byron Byron requested a review from o2sh as a code owner June 29, 2023 11:06
@Byron
Copy link
Collaborator Author

Byron commented Jun 29, 2023

It seems that the cache is getting in the way of even compiling successfully, and I don't know how to fix that.

In theory, this PR already works and adds support for commits with early commit dates, so this repository could be visualized fi there was any code in it. Maybe that would also be an avenue of improvement for another day.

@spenserblack
Copy link
Collaborator

It seems that the cache is getting in the way of even compiling successfully, and I don't know how to fix that.

Perhaps a call to cargo update to update the sub-dependencies? Although if one of our dependencies tries to enable a feature that doesn't exist, that's a sign that perhaps its version constraint isn't strict enough.

@Byron
Copy link
Collaborator Author

Byron commented Jun 29, 2023

A great idea, let me try that. GitHub also just had some general CI issues, I hope that's not interfering now.

spenserblack
spenserblack approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is passing 🎉

@Byron
Copy link
Collaborator Author

Byron commented Jul 1, 2023

Thanks a lot for the test, much better now!

@o2sh o2sh merged commit 67cd11a into o2sh:main Jul 1, 2023
12 checks passed
@Byron Byron deleted the negative-dates branch July 1, 2023 13:52
@o2sh o2sh added the fix label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

@o2sh o2sh Awaiting requested review from o2sh o2sh is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Byron @spenserblack @o2sh