Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add german translation of README.md #1236

Merged
merged 13 commits into from Dec 17, 2023
Merged

Add german translation of README.md #1236

merged 13 commits into from Dec 17, 2023

Conversation

rdwz
Copy link
Contributor

@rdwz rdwz commented Dec 16, 2023

  • Create docs/README.de.md
  • Update README.md

solves #1235

spenserblack
spenserblack requested changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Just had one question and one issue with Markdown syntax.

README.md Show resolved Hide resolved
docs/README.de.md Outdated Show resolved Hide resolved
docs/README.de.md Show resolved Hide resolved
@rdwz @spenserblack
Apply suggestions from code review
0a8ff1c 
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
spenserblack
spenserblack requested changes Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
rdwz
rdwz commented Dec 16, 2023
View reviewed changes
Copy link
Contributor Author

@rdwz rdwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all requests resolved

spenserblack
spenserblack reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
o2sh
o2sh reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
o2sh
o2sh reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
o2sh
o2sh reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
o2sh
o2sh reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
o2sh
o2sh reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
o2sh
o2sh reviewed Dec 16, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
spenserblack
spenserblack requested changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch, @o2sh!

rdwz and others added 6 commits December 17, 2023 05:41
@rdwz @o2sh
Update docs/README.de.md
a29faaa 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@rdwz @o2sh
Update docs/README.de.md
8d544c5 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@rdwz @o2sh
Update docs/README.de.md
7afd194 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@rdwz @o2sh
Update docs/README.de.md
897636f 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@rdwz @o2sh
Update docs/README.de.md
b36555c 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@rdwz @o2sh
Update docs/README.de.md
d807829 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
o2sh
o2sh reviewed Dec 17, 2023
View reviewed changes
docs/README.de.md Outdated Show resolved Hide resolved
@rdwz @o2sh
Apply suggestions from code review
3d9f954 
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
rdwz
rdwz commented Dec 17, 2023
View reviewed changes
Copy link
Contributor Author

@rdwz rdwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paths updated

@rdwz
Update README.de.md
b6175ec 
revert translated badgelink
@o2sh o2sh merged commit 90bcba4 into o2sh:main Dec 17, 2023
1 check passed
@o2sh
Copy link
Owner

o2sh commented Dec 17, 2023 •
edited

Thanks a lot for you contribution @rdwz and @spenserblack for the the review

I'm sure this will be very helpful for German users👍

🎉

@o2sh o2sh added the doc label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o2sh o2sh o2sh left review comments

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdwz @o2sh @spenserblack