Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Default color instead of White #625

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Use Default color instead of White #625

merged 1 commit into from
Mar 22, 2022

Conversation

spenserblack
Copy link
Collaborator

@spenserblack spenserblack commented Mar 22, 2022

Allows the "white" color to have the greatest chance of being a dark,
visible color for light terminal themes. A macro is used to remap
White to Default to minimize size of the diff and prevent
contributors from needing to be familiar with the Default color on top
of the 8 standard colors.

For #33
Supersedes #611

TODO

  • Review other uses of White where Default should be used

@spenserblack
Copy link
Collaborator Author

Sadly, I believe this does break the artistic intent of some logos on light terminals. For example, the Golang Gopher's eyes will have black sclera and white pupils on a light terminal. However, before this change, the white-on-white coloration of the gopher's eyes would give it the appearance of empty eye sockets.

I think that, to a certain extent, breakage of artistic intent is unavoidable on a light terminal, as many logos assume that empty space will be black. In other words, many of these logos were designed on and for a black "canvas".

@o2sh
Copy link
Owner

o2sh commented Mar 22, 2022

I think that, to a certain extent, breakage of artistic intent is unavoidable on a light terminal, as many logos assume that empty space will be black. In other words, many of these logos were designed on and for a black "canvas".

Yeah, dark terminals are the de facto standard and all logos should be designed with black "canvas" in mind first. Mapping White to default is the best compromise IMO.

Allows the "white" color to have the greatest chance of being a dark,
visible color for light terminal themes.

A macro is used to remap `White` to `Default` to minimize size of the
diff and prevent contributors from needing to be familiar with the
`Default` color on top of the 8 standard colors.

In other places where `White` was assumed to be the default, `Default`
is now used instead, also.

For #33
Closes #611
@spenserblack spenserblack marked this pull request as ready for review March 22, 2022 13:09
@spenserblack
Copy link
Collaborator Author

I didn't modify num_to_color. Even though this a function with a very similar implementation in neofetch, num_to_color is pretty much only for user-specified overrides, and I think we can trust users to choose the correct foreground color.

@o2sh o2sh merged commit 7b89eff into o2sh:main Mar 22, 2022
@spenserblack spenserblack deleted the breaking/default-over-white branch March 22, 2022 13:57
src/info/mod.rs Show resolved Hide resolved
o2sh pushed a commit that referenced this pull request Mar 23, 2022
The language blocks use background coloring for their styling. The
default coloring is the background itself, rendering the block
invisible. This reverts the change introduced in #625 to use `Default`
instead of `White` for the "other" block.

See #625 (comment)
@o2sh o2sh mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants