Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language support for VHDL #632

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Add language support for VHDL #632

merged 4 commits into from
Mar 29, 2022

Conversation

BHatGuy
Copy link
Contributor

@BHatGuy BHatGuy commented Mar 28, 2022

Adds support for VHDL (#490). Sadly VHDL has no official logo, so I just used the name.

Adds support for VHDL (o2sh#495). Sadly VHDL has no official logo
@spenserblack
Copy link
Collaborator

Thank you! Very nice 3D effect with the ASCII.

Sadly VHDL has no official logo

It's definitely hard to make an ASCII logo with no official logo for reference 😢
How did you decide on green for the color? What do you think about making the letters different colors to make the ASCII more eye-catching?

@o2sh
Copy link
Owner

o2sh commented Mar 28, 2022

What about using a micro chip as an illustration? similarly to what we did for SQL and Fortran:

Screenshot 2022-03-28 at 23 19 47

        |  |  |  |
       ------------
    --|    ----    |--
    --|   |    |   |--
    --|   |    |   |--
    --|    ----    |--
       ------------
        |  |  |  |

__     ___   _ ____  _
\ \   / / | | |  _ \| |
 \ \ / /| |_| | | | | |
  \ V / |  _  | |_| | |___
   \_/  |_| |_|____/|_____|

@BHatGuy
Copy link
Contributor Author

BHatGuy commented Mar 29, 2022

Yes, this looks nice

@spenserblack
Copy link
Collaborator

Could you resolve the conflict? #630 introduced a new field when defining language support.

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just curious: how did you decide on the colors Cyan and Yellow?

@BHatGuy
Copy link
Contributor Author

BHatGuy commented Mar 29, 2022

I don't really know. I think it looks nice

@spenserblack
Copy link
Collaborator

I think it looks nice

Agreed 🙂

Although I wonder if green and yellow would better represent a microchip. @o2sh What do you think?

@o2sh
Copy link
Owner

o2sh commented Mar 29, 2022

Option 1:
Screenshot 2022-03-29 at 21 15 00

Option 2 (as suggested by @spenserblack):
Screenshot 2022-03-29 at 21 53 15

I personally lean toward Option 2 🤔

Code for Option 2:

{0}         |  |  |  |
{0}        {1}------------
{0}     --{1}|    {2}----    {1}|{0}--
{0}     --{1}|   {2}|    |   {1}|{0}--
{0}     --{1}|   {2}|    |   {1}|{0}--
{0}     --{1}|    {2}----    {1}|{0}--
{0}        {1}------------
{0}         |  |  |  |

{2} __     ___   _ ____  _
{2} \ \   / / | | |  _ \| |
{2}  \ \ / /| |_| | | | | |
{2}   \ V / |  _  | |_| | |___
{2}    \_/  |_| |_|____/|_____|

{ Vhdl, Programming, "vhdl.ascii", define_colors!([Yellow, Green, White]), Rgb(173, 178, 203) },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants