Add --completion option
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used for generating completions.
Generates completions for the specified shell. This commit also - Creates a separate `build_cli` fn. Necessary as CLI has to be rebuilt for completion generation. - Changes a few iter borrows to take the values. Necessary for CLI App struct's lifetime.
|
Note that the "real" diff is actually much smaller than the git diff. A simple change in indentation results in a massive number of lines changed 🤣 |
o2sh
reviewed
May 6, 2022
o2sh
reviewed
May 6, 2022
o2sh
reviewed
May 6, 2022
o2sh
approved these changes
May 6, 2022
o2sh
reviewed
May 6, 2022
#657 (comment) Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
o2sh
approved these changes
May 6, 2022
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
#657 (comment) Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
#657 (comment) Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to generate completions by passing
--completion <SHELL>. This PR alsobuild_clifunction. This was necessary as theclap_generatedocs seem to imply that a separate instance of the CLI app struct is necessaryfor generating completions. For the purposes of the App struct's lifetime, a few borrowed
iterators had to be changed to be taken by the app struct.