Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP colors #664

Merged
merged 7 commits into from
May 13, 2022
Merged

Update PHP colors #664

merged 7 commits into from
May 13, 2022

Conversation

DenverCoder1
Copy link
Contributor

@DenverCoder1 DenverCoder1 commented May 12, 2022

Currently, the onefetch PHP logo uses very vibrant colors and not the colors used in the original PHP logo.

This updates the ascii art for PHP to more closely resemble the PHP logo.

Current logo:
image

Updated preview:
image

Alternate versions (outdated)

Source for logo / colors: https://www.php.net/download-logos.php

@DenverCoder1 DenverCoder1 marked this pull request as draft May 12, 2022 02:28
@DenverCoder1 DenverCoder1 marked this pull request as ready for review May 12, 2022 02:35
src/info/langs/language.rs Outdated Show resolved Hide resolved
@o2sh
Copy link
Owner

o2sh commented May 12, 2022

Thanks a lot @DenverCoder1,
Even though I love the neon/retro look, your point is valid.
We should always - whenever possible - respect the logo's original design.

@o2sh
Copy link
Owner

o2sh commented May 12, 2022

Here is a suggestion (more white countering and revert to a simpler charset), tell me what you think:

Screenshot 2022-05-12 at 11 18 10

{0}            ################
{0}      ##########{1}/  |{0}##############
{0}   #############{1}|  |{0}#################
{0} #####{1}/   __   \|   __   \/   __   \{0}###
{0}######{1}|  |{0}##{1}|  ||  |{0}##{1}|  ||  |{0}##{1}|  |{0}####
{0}######{1}|  |{0}##{1}/  ||  |{0}##{1}|  ||  |{0}##{1}/  |{0}####
{0} #####{1}|   ____ /|__|{0}##{1}|__||   ____ /{0}###
{0}   ###{1}|  |{0}################{1}|  |{0}#######
{1}      |_ /{0}################{1}|_ /{0}####
{0}            ################

DenverCoder1 and others added 2 commits May 12, 2022 05:50
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@DenverCoder1
Copy link
Contributor Author

I made the changes. Any idea why the checks are failing now?

I don't see any reason why changing Magenta to Blue would cause that.

@spenserblack
Copy link
Collaborator

It's most likely a conditional compilation of one of our dependencies that's failing, since nightly is unstable.

@spenserblack
Copy link
Collaborator

@o2sh
Copy link
Owner

o2sh commented May 12, 2022

Well, that's unfortunate.
libz-sys isn't a direct dependency of onefetch. Do you suggest we add it in the Cargo.toml with the latest version?

@spenserblack
Copy link
Collaborator

No, I think we can just use cargo update to update it in the Cargo.lock. Just making sure you're on board with that, and that I'm not mistaken. Anyone have a Windows machine to test on?

@o2sh
Copy link
Owner

o2sh commented May 13, 2022

done 638e12c
I think we can merge this branch.

Thanks a lot @DenverCoder1

@o2sh o2sh merged commit 415c460 into o2sh:main May 13, 2022
@DenverCoder1 DenverCoder1 deleted the php-update branch December 16, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants