Ignore docs for CI runs #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will only run the CI if a contributor has edited - the `src/` directory - the `resources/` directory - the manifest files This prevents unnecessary workflow runs. For example, on documentation changes.
o2sh
approved these changes
Jun 30, 2022
.github/workflows/ci.yml
Outdated
Comment on lines
5
to
8
| paths: | ||
| - 'src/**' | ||
| - 'resources/**' | ||
| - 'Cargo.*' |
There was a problem hiding this comment.
Suggested change
| paths: | |
| - 'src/**' | |
| - 'resources/**' | |
| - 'Cargo.*' | |
| paths-ignore: | |
| - "docs/**" | |
| - "**.md" |
It may be safer that way.
There was a problem hiding this comment.
Yeah, I was debating between the two, but you're probably right. But there are a lot of other paths to ignore: assets, config files, etc. But this should prevent the majority of unnecessary runs, so applying.
Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only run the CI if a contributor has edited
src/directoryresources/directoryThis prevents unnecessary workflow runs. For example, on documentation
changes.
For example, #693 didn't need to be in a "workflow run pending" status since none of the changes are tested by the workflow.