-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contributors templates documentation #695
contributors templates documentation #695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From #693
@o2sh Perhaps we should look into using markdown partials/templates so that documentation contributors, especially translators, don't have to repeat anything, like badge links.
@Kaderovski:
Like : #695 ?
@Kaderovski kind of, yeah. Ideally the translation documents (readme.fr.md
, etc.) would be built by a workflow. The lowlighter/metrics repository has examples of using partials and building them with a script. We don't need something nearly as complex as that solution, but if we could get to a point somehow where a translation is parsed into a README template (or badges are parsed into a translation?), possibly in an automated way, that would be pretty cool.
But your PR now is OK for me, with one small change.
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
I've also seen this method on other repos (if it might help?)
Full example on Catppuccin https://github.com/catppuccin/catppuccin/blob/main/docs/contributing.md#creation |
That's a pretty interesting solution! I'll have to think about the best way to accomplish this, but I'd like to make it as easy for contributors as possible. Thinking purely from a contributor workflow, something like this:
And on our end something like this: Besides ease of contributing, my secondary goal (OK, maybe actually primary 😅) is to reduce duplicated work as much as possible (e.g. changing image links). This does add some complication to the repo though, possibly enough to warrant a separate docs repo, so it may not be worth it. Edit: oh, nevermind, we won't need a separate repo because there could be an orphaned branch like |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@spenserblack, @o2sh can this help ?