Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributors templates documentation #695

Conversation

LeBaronDeCharlus
Copy link
Contributor

@spenserblack, @o2sh can this help ?

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #693

@spenserblack:

@o2sh Perhaps we should look into using markdown partials/templates so that documentation contributors, especially translators, don't have to repeat anything, like badge links.

@Kaderovski:

Like : #695 ?


@Kaderovski kind of, yeah. Ideally the translation documents (readme.fr.md, etc.) would be built by a workflow. The lowlighter/metrics repository has examples of using partials and building them with a script. We don't need something nearly as complex as that solution, but if we could get to a point somehow where a translation is parsed into a README template (or badges are parsed into a translation?), possibly in an automated way, that would be pretty cool.

But your PR now is OK for me, with one small change.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
@LeBaronDeCharlus
Copy link
Contributor Author

LeBaronDeCharlus commented Jun 28, 2022

I've also seen this method on other repos (if it might help?)

  • [you] create a onefetch/template repo (where you put basically the skeleton markdown template)
  • [contributor] will create a repo on their own & leave it empty
  • [contributor] add onefetch template as a remote: git remote add template git@github.com:onefetch/template.git
  • [contributor] pull from it: git pull template main --depth=1
  • [contributor] delete the remote: git remote remove template
  • [contributor] then they can work directly with

Full example on Catppuccin https://github.com/catppuccin/catppuccin/blob/main/docs/contributing.md#creation

@spenserblack
Copy link
Collaborator

spenserblack commented Jun 28, 2022

I've also seen this method on other repos (if it might help?)
...

That's a pretty interesting solution! I'll have to think about the best way to accomplish this, but I'd like to make it as easy for contributors as possible. Thinking purely from a contributor workflow, something like this:

  1. fork onefetch
  2. create a file like fr.translation.<extension> (maybe YAML?)
  3. make PR

And on our end something like this:
on push to main with path docs/translations: parse values from translation file to template

Besides ease of contributing, my secondary goal (OK, maybe actually primary 😅) is to reduce duplicated work as much as possible (e.g. changing image links). This does add some complication to the repo though, possibly enough to warrant a separate docs repo, so it may not be worth it.

Edit: oh, nevermind, we won't need a separate repo because there could be an orphaned branch like gh-pages. Totally forgot about that 😅 🤦

@o2sh
Copy link
Owner

o2sh commented Oct 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Oct 2, 2022
@o2sh o2sh closed this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants