Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSX ASCII logo #784

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Improve JSX ASCII logo #784

merged 4 commits into from
Oct 2, 2022

Conversation

alessandroasm
Copy link
Contributor

This is part of the improvements requested by Issue #777

This is part of the improvements requested by Issue #777
@o2sh
Copy link
Owner

o2sh commented Oct 2, 2022

That's a very cool design 👍

I cleaned it a little, tell me what you think.

image


  ascii: |
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJSX{1}JSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJS{1}XJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJ{1}SXJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJSX{1}JSXJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSXSJ{1}SXJSXJS
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSXJ{1}SXJSXJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJSX{1}JSXJSXJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJS{1}XJSXJSXJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSXJ{1}SXJSXJSXJSX
    {0}JSXJSXJSXJSXJSXJSXJSXJSXJSX{1}JSXJSXJSXJSX
    {0}JSXJSXJ   SX      JSXJSXJS{1}X{2}JSX{1}JSX{2}JSX{1}JSX
    {0}JSXJSXJ   S   XJSXJSXSJSX{1}JSX{2}JSX{1}J{2}SXJ{1}SXJS
    {0}JSXJSXJ   SXJ   SXJSXJSX{1}JSXJSX{2}JSX{1}JSXJSX
    {0}JSXJSXJ   SXJSX   JSXJS{1}XJSXJS{2}XJSXJ{1}SXJSX
    {0}JS   XJ   S   XJ   SXJ{1}SXJSXJ{2}SXJ{1}S{2}XJS{1}XJSX
    {0}JSX      JSX      JSX{1}JSXJSX{2}JSX{1}JSX{2}JSX{1}JSX
    {0}JSXJSXJSXJSXJSXJSXJS{1}XJSXJSXJSXJSXJSXJSX
  colors:
    ansi:
      - yellow
      - magenta
      - white
    hex:
      - '#FAE354'
      - '#B684D3'
      - '#F3EAF8'

@alessandroasm
Copy link
Contributor Author

@o2sh Wow, that is really awesome! I liked the cleaner version a lot!

I'm gonna update the PR with it 👍

languages.yaml Outdated Show resolved Hide resolved
languages.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first contribution @alessandroasm 🎉

I left some minor remarks.

As suggested by @o2sh
@alessandroasm
Copy link
Contributor Author

@o2sh Awesome! Thank you!
I just fixed all the issues you pointed, thank you again.

@o2sh o2sh self-requested a review October 2, 2022 13:00
languages.yaml Outdated Show resolved Hide resolved
languages.yaml Outdated Show resolved Hide resolved
Using the same colors used by JS. Suggested by @o2sh.
@alessandroasm
Copy link
Contributor Author

@o2sh Colors fixed 👍
Thank you again.

@o2sh o2sh merged commit 1ab5be9 into o2sh:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants