Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ruby logo #777 #786

Merged
merged 4 commits into from
Oct 4, 2022
Merged

improve ruby logo #777 #786

merged 4 commits into from
Oct 4, 2022

Conversation

atluft
Copy link
Contributor

@atluft atluft commented Oct 2, 2022

First attempt to improve ruby logo.

Before -> After
image image

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty cool!
I'm curious how it would look with 2 shades of red (true color only) for the outline and the inside of the logo. Approving since I think this looks pretty good, but you might want to play around with it and see how it looks.

@spenserblack
Copy link
Collaborator

And congratulations on lucky number 777 for your PR 😆

@atluft
Copy link
Contributor Author

atluft commented Oct 2, 2022

I was thinking the same thing!

True color using 2 shades of red:

image

@o2sh
Copy link
Owner

o2sh commented Oct 3, 2022

Looks really cool @atluft

I know it's hard to do, but the inner shapes could be better aligned IMO:

image

Sorry for cherry picking and props to you if you can do it 👍

@atluft
Copy link
Contributor Author

atluft commented Oct 3, 2022

Hi @o2sh
Fair comment, this one is hard.
Check this link on how to draw a ruby
Looks clumsy, will see if I can straighten.

@atluft
Copy link
Contributor Author

atluft commented Oct 4, 2022

Well that was hard, its ok.

image

@o2sh o2sh merged commit b9b57a7 into o2sh:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants