Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLSL language support #490 #824

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Add GLSL language support #490 #824

merged 3 commits into from
Feb 15, 2023

Conversation

sangsatori
Copy link
Contributor

Logo is a mash-up of OpenGL and OpenGL ES logos.
All tests pass.

Logo is a mash-up of OpenGL and OpenGL ES logos.
All tests pass.
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary colors from those two logos look pretty good combined IMO

@spenserblack
Copy link
Collaborator

@o2sh Any feedback before we merge this?

@o2sh
Copy link
Owner

o2sh commented Feb 13, 2023

Yes, sorry about the delay 😓 I'll try to find some time this week to review this PR.

The ASCII art could be cleaned/improved, IMO. I'll come back with a suggestion as soon as possible.

Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @sangsatori and sorry for the late review.

I left a suggestion.

languages.yaml Outdated Show resolved Hide resolved
@spenserblack
Copy link
Collaborator

As a side-note, I wonder if we can update CONTRIBUTING.md to add some guidelines on authoring ASCII. Useful characters, how to round edges, opacity levels, stuff like that.

Slight changes based on cleaned-up logo by @o2sh
o2sh#824 (comment)
@o2sh
Copy link
Owner

o2sh commented Feb 15, 2023

I'm afraid that if we enforce guidelines for ASCII art creation, it could go against contributors' creativity and result in uniform-looking designs 🤔 . IMO, we should encourage contributors to express their creativity and come up with unique designs that complement the original logo.

Even it means making minor adjustments if necessary 😅

@o2sh o2sh merged commit a029938 into o2sh:main Feb 15, 2023
@sangsatori sangsatori deleted the add-lang-glsl branch February 15, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants