Add test info mod rs

[atluft]

Rebased PR #822
Didn't realize that would close the other PR, sorry.

[atluft]

Trying a new approach in 3e2757d
Test creates repo and expected result using shell script via git-testttools
Test reads expected result from file created by shell script
Test perform action
Test compare actual to expected

Thinking about how to handle git version (like excluding it) and removing colors.

[spenserblack]

These assertion diffs are pretty hard to read 😆
I've used pretty_assertions before to get better diffs.

[atluft]

Thank you @spenserblack , here is a pretty assertion:

[atluft]

@spenserblack and @o2sh
Really like the output of pretty_assert that is very easy to see the issues.

What are thoughts on using regular expressions in the expected output?
I have the wrong regex for REGEX_ANYTHING, ".*" is only good for end of lines.
Wanted a quick review and collect ideas before putting too much effort into this.

Would this be better if a phrases were used: MATCH_UNTIL_END_OF_LINE or MATCH_WORD ?

[spenserblack]

Those diffs look much better now, thank you!

[spenserblack]

Testing against a regex, and stripping out the ANSI escape sequences, looks much better IMO! 👍
Almost there! Just a few more comments.

[spenserblack]

Now I want to write a macro to better support snapshot testing 😆

[spenserblack]

Here I was about to make a snapshot testing library, and in my research found that one exists 😆
https://crates.io/crates/insta

It might be worth using this library for the JSON output test.

[atluft]

Have a look at 6486d50

Ugh, then have a look at 75b427c for the insta snapshot file. The .gitignore file has *.snap in it to ignore snapshots.

Insta setup went like this:

  cargo add --dev insta --features json,redaction,redactions
  cargo install cargo-insta
# add assert_json_snapshot to code
  cargo test -- --nocapture
  cargo insta review

[spenserblack]

Great work!

The .gitignore file has *.snap in it to ignore snapshots.

We might want to adjust the .gitignore so that it ignores only the files it should ignore.

@o2sh Do you remember why *.snap is in the .gitignore?

[o2sh]

@o2sh Do you remember why *.snap is in the .gitignore?

If I remember correctly, this line was added for when I used to build the snapcraft package locally before publishing it to the Snap store - which is now done automatically via a Github link.

I think this line can be safely removed.

[atluft]

Change 69c6229 caused a snapshot change, testing gitignore change ;-)

Also, gave another chance to use cargo insta review that is so cool how it "fixes" up the snapshot file for the test.

[spenserblack]

that is so cool how it "fixes" up the snapshot file for the test.

Yeah, snapshot testing is pretty interesting. It leans a bit towards "acceptance". That is, instead of a human writing a test for the machine to run and the code to pass, a human reviews the output and tells the machine if they like it.