Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo without remote should not fail #841

Merged
merged 3 commits into from
Oct 30, 2022
Merged

Repo without remote should not fail #841

merged 3 commits into from
Oct 30, 2022

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Oct 30, 2022 •
edited
Loading

Fix for #832

@o2sh o2sh requested a review from Byron as a code owner October 30, 2022 11:41
@o2sh o2sh changed the title repo without remote should not fail Repo without remote should not fail Oct 30, 2022
Byron
Byron approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking in with me, all looks good. I always like seeing git-testtools coming to good use here as well.

@o2sh o2sh merged commit e72f371 into main Oct 30, 2022
@o2sh o2sh deleted the fix/repo_without_remote branch October 30, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@o2sh @Byron