Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn AsciiArt.rs into its own crate #934

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Turn AsciiArt.rs into its own crate #934

merged 4 commits into from
Jan 18, 2023

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Jan 18, 2023

refers to #931

spenserblack
spenserblack reviewed Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ascii/README.md is an empty file. Should it be a symlink?

@o2sh
Copy link
Owner Author

o2sh commented Jan 18, 2023 •
edited
Loading

Looks like ascii/README.md is an empty file. Should it be a symlink?

Sorry about that, It wasn't ready, I forgot to mark it as a draft 😓

I added a very short readme.

Even though the code is quite clear, this crate is lacking documentation - same applies to image and manifest BTW.

spenserblack
spenserblack approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the code is quite clear, this crate is lacking documentation - same applies to image and manifest BTW.

That gives the community a chance to contribute 😆

@o2sh o2sh merged commit 1716519 into main Jan 18, 2023
@o2sh o2sh deleted the chore/ascii-crate branch January 18, 2023 20:45
@o2sh o2sh mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@o2sh @spenserblack