-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ascii): parse multi-byte unicode chars correctly + docs #936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
I'm sure this resolves your issue, but would you want to add a test for it, and reference your issue?
// https://github.com/o2sh/onefetch/issues/935
#[test]
fn test_multi_byte_tokens() {
// ...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for adding tests and docs!
One last nitpick:
Also added badges to the readme, so as to have a direction to the docs.rs/crates.io pages from the repo. To note, it will show not found until there's a release 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
If it's possible, it'd be really nice for this crate to get published asap once merged, so that I can release punfetch with the integrations for color support. Even if it's a |
|
Why
resolves #935
What
AsciiArt
usage exampleascii/README.md
Demo
Usage
Docs