Refactoring of info/langs/mod.rs
#948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| pub fn get_language_statistics( | ||
| pub fn get_loc_by_language_sorted( |
There was a problem hiding this comment.
Better naming for the methods and simplified signatures - up for discussion.
I guess, on this subject, _loc_ could potentially be confusing to new contributors, since "loc" is frequently an abbreviation for "location". lines_by_language_sorted might be slightly more understandable to newcomers.
There was a problem hiding this comment.
Good point, I added some documentation to clarify the terminology and explain the method's intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folllowing #937, I couldn't help but notice that
info/langs/mod.rscould need some refactoring for better readability but also for performance reasons.Covered in this PR:
language::locis called only inget_loc_by_languageand reused inget_total_locinfo/langs/mod.rsinto their respective info fields:LanguageInfoandLocInfo