Fixing the progress bar #33
Comments
|
The library halo (https://github.com/ManrajGrover/halo) will be used. It doesn't have full Windows support, but works well enough for what has to be done. |
|
Honestly, I could make a module using ANSI escape codes to do the progress bar. It would be Windows compatible (plus chopping off a dependency). Let me know what you think!
Benjamin Urquhart, President of Imfazwe.
… On Oct 7, 2017, at 6:18 PM, o355 ***@***.***> wrote:
The library halo (https://github.com/ManrajGrover/halo) will be used. It doesn't have full Windows support, but works well enough for what has to be done.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The halo library works well for my purposes on Windows. I did a test run on Win 10 and felt as if it worked and was easy to implement. Of course I'm going to do further testing on OS X and Linux when I can. |
|
Ok then :)
… On Oct 7, 2017, at 9:45 PM, o355 ***@***.***> wrote:
The halo library works well for my purposes on Windows. I did a test run on Win 10 and felt as if it worked and was easy to implement.
Of course I'm going to do further testing on OS X and Linux when I can.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Enhancement suspended temporarily, issues with the library were encountered. |
|
Would you like me to make the custom module now? :P
…On Mon, Oct 16, 2017 at 11:58 PM, o355 ***@***.***> wrote:
Enhancement suspended temporarily, issues with the library were
encountered.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#33 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXjru16O6PPgazewqBAQmLzTWgv1J8YVks5stCXngaJpZM4PqhKx>
.
|
|
I've contacted the developers on GitHub, no response for 3 days. I'm going to give them a week and then I'll give you permission to make the custom module, since I like having a fancy spinner. |
|
Ok
|
|
Development is now unsuspended. I'm going to investigate potential methods about using Halo, and potentially pushing back the feature to 0.6.4 beta since it may require monumental codebase changes. @creepersbane, I appreciate your willingness to make a custom library! If you'd like to make one that'd be great, just to have a backup plan. If you can, try to get your package on PyPi, and I'll email you with more details. |
|
I already have >:)
It's still a W.I.P, but you can see it at https://github.com/creepersbane/loading-spinner.
If you want to try it, make sure you import spin_mod, NOT spinner.
On Oct 20, 2017, at 8:21 PM, o355 <notifications@github.com> wrote:
Development is now unsuspended. I'm going to investigate potential methods about using Halo, and potentially pushing back the feature to 0.6.4 beta since it may require monumental codebase changes.
@creepersbane, I appreciate your willingness to make a custom library! If you'd like to make one that'd be great, just to have a backup plan. If you can, try to get your package on PyPi, and I'll email you with more details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Awesome! I'll try it out when I get the chance. |
|
Update: Two developers from their side have claimed that this is an odd issue, one of which mentioned that the code worked fine on their system. I'm going to investigate into more detail why this is occurring. I'm starting to think it's an issue with the command prompt on my machine, or that it's good 'ol Windows 10. |
|
Ok then. Status on the custom library: Spinner text colors: 100% (use setTextColor(color) to set the color) |
|
Alright. I'm considering using your library instead, but just make sure you get it up on PyPi so that users can download it with pip install. |
|
Ok |
|
Hey @creepersbane, I've decided to bite the bullet and stick with Halo for now. Halo is an official library which has been starred thousands of times, and even though I have to add 500ish Thank you for your willingness to make a library for PyWeather, nonetheless. Development of the spinner has resumed. |
|
Ok. I'm still adding it to Pypi though :)
On Oct 25, 2017, at 10:45 AM, o355 <notifications@github.com> wrote:
Hey @creepersbane, I've decided to bite the bullet and stick with Halo for now.
Halo is an official library which has been starred thousands of times, and even though I have to add 500ish Style.BRIGHT statements, I should of done that when I first did color in PyWeather.
Thank you for your willingness to make a library for PyWeather, nonetheless.
Development of the spinner has resumed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
FYI, the text dimming with halo happens to me as well (Ubuntu 14.0.4 xenial) |
|
I sent an email that should show up here...well thanks GitHub |
|
It showed up.
On Oct 25, 2017, at 2:12 PM, o355 <notifications@github.com> wrote:
I sent an email that should show up here...well thanks GitHub
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Cool. If you wouldn't mind, it'd be nice if you could subscribe to the weekly mailing letter for PyWeather's latest news. I don't want Mailerlite kicking me for using their service unnecessarily. Link is in the readme. |
|
Eh, OK? |
|
Progress bar work is now almost done! I'll now be looking over code to see if all the necessary spinners are implemented, and most colors are brightened up. I'm leaving alone color on the block of code for detailed yesterday's weather as to prevent any merge errors. |
|
I'm not getting any emails.
On Oct 25, 2017, at 8:02 PM, o355 <notifications@github.com> wrote:
Cool. If you wouldn't mind, it'd be nice if you could subscribe to the weekly mailing letter for PyWeather's latest news. I don't want Mailerlite kicking me for using their service unnecessarily.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Done, I actually can't believe the code for 0.6.3 beta is done butttt it's QA time |
|
Just as a little gag, set the spinner text at the very end after fetching the weather to "Voting for net neutrality..." :)
On Nov 9, 2017, at 8:16 AM, o355 <notifications@github.com> wrote:
Closed #33.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
It's a good idea but the text would either flash on screen for 50ms or I'd have to intentionally put a sleep for maybe 300ms to show the spinner. |
|
Make it flash so people will double take :)
On Nov 25, 2017, at 7:01 PM, o355 <notifications@github.com> wrote:
It's a good idea but the text would either flash on screen for 50ms or I'd have to intentionally put a sleep for maybe 300ms to show the spinner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Presently the progress bar in PyWeather is a complete mess. I've been looking around for a library that can support the variability that comes with booting PyWeather (some people might have 15 or 25 steps to boot).
I found a cool library called Halo on /r/coolgithubprojects, but it lacks Windows support at the moment.
The text was updated successfully, but these errors were encountered: