Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowering default data iterations #60

Open
1 of 3 tasks
o355 opened this issue Feb 9, 2018 · 7 comments
Open
1 of 3 tasks

Lowering default data iterations #60

o355 opened this issue Feb 9, 2018 · 7 comments
Milestone

Comments

@o355
Copy link
Owner

o355 commented Feb 9, 2018

Lowering default data iterations in PyWeather for better readability. Before this gets started I will do a very conclusive study about how much data different terminals on different screens can render.

After that I'll decide on an iteration count that works well. Right now, the 5+ iteration method is only good for full-screen terminals.

To-do list:

  • Find the right amount of iterations per data type
  • Implement the new default values into all setup scripts (issue Separating iteration configs for data types #85 is taking care of this)
  • Somehow find a way to ask the user if they'd like to lower default iterations when in configupdate.py.
@o355 o355 added this to the 0.6.4 beta milestone Feb 9, 2018
@o355
Copy link
Owner Author

o355 commented May 30, 2018

Work has started to begin on this "fix". I'll just be testing how many iterations on average we can see on a few computers.

ETA is 6/4 for a fix.

@o355
Copy link
Owner Author

o355 commented May 30, 2018

I've tested iterations on default sizes of terminals on KDE neon, Termux for Android, Windows 10 (PowerShell and the default command prompt), and through Bitvise SSH connecting to a Raspberry Pi.

I still need to test out macOS but here's what I've sound so far for default iterations:

  • 1.5 day/10 day hourly: 2 iterations before prompt
  • 10 day forecast: 3 iterations before prompt
  • Tide: 6 iterations before prompt
  • Historical hourly: 2 iterations before prompt
  • Yesterday hourly: 3 iterations before prompt

PowerShell had some crazy high numbers as to what it could fit, so it's an outlier in this experiment. I couldn't test hurricane data as there aren't any hurricanes floating around, but I may be able to down the road.

@o355
Copy link
Owner Author

o355 commented May 30, 2018

Hey sometimes the notes widget data just gets deleted, so the default iterations above is what we're sticking with. I'll still test macOS to see what works.

@o355
Copy link
Owner Author

o355 commented May 30, 2018

Here's a fun issue: For whatever reason there isn't any option for configuring iterations during config load. Will investigate more...

@o355
Copy link
Owner Author

o355 commented May 30, 2018

To complete this issue, we need to add code to separate out how many iterations occur for each data type. Right now multiple data types rely on a single variable.

There goes the thought of PyWeather 1.0.0 being ahead of schedule

@o355
Copy link
Owner Author

o355 commented May 30, 2018

MacOS does appear to be a bit on the lower side of the iteration table. 1 iteration for hourly data (but the 2nd one is entirely visible, just not the date).

Forecast data is 2 iterations. Tide data is 5-6 iterations,

On the bright side it's a solid 2 iterations for historical hourly. But then it's sad because 2.5 iterations for yesterday hourly.

I think I'll keep things the same for now.

@BenjaminUrquhart
Copy link
Contributor

BenjaminUrquhart commented Jun 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants