docker environment for Ros2ProjectTemplate #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
jhanca-robotecai
changed the title
pijaro
requested changes
Jun 30, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
pijaro
approved these changes
Jul 11, 2023
pawelbudziszewski
approved these changes
Jul 11, 2023
|
I've tested it and it works fine. |
adamdbrw
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the last point in the #246 issue. Please double check if #246 can be closed.
The Dockerfile and the remaining files are based on the https://github.com/o3de/RobotVacuumSample docker configuration.
Open questions:
-> if the option to keep this folder top of the repo is selected, an argument to switch between Ros2FleetRobotTemplate and Ros2ProjectTemplate should be added
-> the target for this PR is
developmentbranch; I believe iron should be the target for the next stable release