Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suffix to collider meshes during import #371

Merged
merged 1 commit into from Jul 3, 2023
Merged

Add suffix to collider meshes during import #371

merged 1 commit into from Jul 3, 2023

Conversation

michalpelka
Copy link
Contributor

Fixes #370 by adding "_collision" suffix to the collider's source asset.

@michalpelka
Add suffix to collider meshes during import
736480b 
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
@michalpelka michalpelka requested review from a team as code owners June 23, 2023 11:13
nick-l-o3de
nick-l-o3de approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@nick-l-o3de nick-l-o3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Is this to prevent name-collisions?

@michalpelka
Copy link
Contributor Author

@nick-l-o3de correct, it is to prevent collisions. The failing case is explained in #370.

@adamdbrw adamdbrw merged commit 51d62ab into o3de:development Jul 3, 2023
2 checks passed
@adamdbrw adamdbrw mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbrw adamdbrw adamdbrw approved these changes

@nick-l-o3de nick-l-o3de nick-l-o3de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URDF importer, filename collisions
3 participants
@michalpelka @adamdbrw @nick-l-o3de