Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages in Joint Trajectory #386

Merged
merged 4 commits into from Jul 11, 2023
Merged

Error messages in Joint Trajectory #386

merged 4 commits into from Jul 11, 2023

Conversation

lewandowskikacper
Copy link
Contributor

Invalid goals are now accepted, and later aborted with error message explaining the reason. Addresses #375.

@lewandowskikacper
Accept goals and abort with explanation
7327aa5 
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
@lewandowskikacper lewandowskikacper requested review from a team as code owners July 6, 2023 14:04
@michalpelka michalpelka added sig/simulation Categorizes an issue or PR as relevant to SIG Simulation feature/robotics This item is related to robotics. kind/feature Categorizes issue or PR as related to a new feature. status/backlog Indicates this is not actively being worked on and is in the backlog. labels Jul 7, 2023
adamdbrw
adamdbrw reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment about result passed in error_code, take a look!

Gems/ROS2/Code/Source/Manipulation/FollowJointTrajectoryActionServer.cpp Outdated Show resolved Hide resolved
@lewandowskikacper
marked goal as maybe_unused in GoalReceicedCallback
d1cf18e 
Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
@lewandowskikacper
changed StartTrajectory to use FollowTrajectoryResult, including erro…
5637c5c 
…r_code, forwarding it in abort

Signed-off-by: Kacper Lewandowski <kacper.lewandowski@robotec.ai>
@adamdbrw
Update Gems/ROS2/Code/Source/Manipulation/FollowJointTrajectoryAction…
06f4c2f 
…Server.cpp

Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
@adamdbrw adamdbrw merged commit 46611b1 into o3de:development Jul 11, 2023
2 checks passed
@adamdbrw adamdbrw mentioned this pull request Sep 29, 2023
Closed
@arturkamieniecki arturkamieniecki mentioned this pull request Oct 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbrw adamdbrw adamdbrw approved these changes

@pawelbudziszewski pawelbudziszewski pawelbudziszewski approved these changes

@michalpelka michalpelka Awaiting requested review from michalpelka

Assignees

@lewandowskikacper lewandowskikacper

Labels
feature/robotics This item is related to robotics. kind/feature Categorizes issue or PR as related to a new feature. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation status/backlog Indicates this is not actively being worked on and is in the backlog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lewandowskikacper @adamdbrw @pawelbudziszewski @michalpelka