URDFImporter: Wait for meshes to process #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arturkamieniecki could this be worked into an acceptable change? |
Yes. I'm working on it right now. I just wanted to create a PR so that if it was needed something could be used. |
arturkamieniecki
force-pushed
the
URDFNotImportingMeshes
branch
3 times, most recently
from
c08ccb2
to
d871290
Compare
Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai>
arturkamieniecki
force-pushed
the
URDFNotImportingMeshes
branch
from
d871290
to
b62b264
Compare
|
This PR is now ready for review. The wait for assets function is very similar to the function implemented in the #327 PR. This change removes the temporary directory where assets were stored as it is not necessary in this implementation. |
lemonade-dm
reviewed
Jul 11, 2023
adamdbrw
approved these changes
Jul 17, 2023
Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com>
michalpelka
approved these changes
Jul 20, 2023
Antoni-Robotec
pushed a commit
to Antoni-Robotec/o3de-extras
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai> Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com>
michalpelka
added a commit
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Michał <michal.pelka@robotec.ai>
michalpelka
added a commit
that referenced
this pull request
Aug 28, 2023
- Reverted #400, changing way of source asset are processed during URDF/XACRO/SDF import using temp directory - Fixed misleading warning on creating articulation link Signed-off-by: Michał <michal.pelka@robotec.ai>
adamdbrw
pushed a commit
that referenced
this pull request
Sep 1, 2023
- Reverted #400, changing way of source asset are processed during URDF/XACRO/SDF import using temp directory - Fixed misleading warning on creating articulation links - Use of GetAssetStatus_FlushIO --------- Signed-off-by: Michał <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
- Reverted o3de#400, changing way of source asset are processed during URDF/XACRO/SDF import using temp directory - Fixed misleading warning on creating articulation links - Use of GetAssetStatus_FlushIO --------- Signed-off-by: Michał <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
- Reverted o3de#400, changing way of source asset are processed during URDF/XACRO/SDF import using temp directory - Fixed misleading warning on creating articulation links - Use of GetAssetStatus_FlushIO --------- Signed-off-by: Michał <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Oct 2, 2023
- Reverted o3de#400, changing way of source asset are processed during URDF/XACRO/SDF import using temp directory - Fixed misleading warning on creating articulation links - Use of GetAssetStatus_FlushIO --------- Signed-off-by: Michał <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
that referenced
this pull request
Oct 3, 2023
- Reverted #400, changing way of source asset are processed during URDF/XACRO/SDF import using temp directory - Fixed misleading warning on creating articulation links - Use of GetAssetStatus_FlushIO --------- Signed-off-by: Michał <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the #395 issue.
This PR is WIP.It waits 10 seconds for the assets to be processed.The PR in the current state can be used if the above bug is encountered.The URDF importer was modified to disable watching assets (this breaks the visuals on resolved meshes page).To properly import the URDF after the resolved meshes page is shown for the first time we need to use the back button and then the next button. After that, the meshes should be resolved properrly.