Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the concept of global settings to the SdfAssetBuilder #457

Merged
merged 10 commits into from
Aug 11, 2023
Merged

Add the concept of global settings to the SdfAssetBuilder #457

merged 10 commits into from
Aug 11, 2023

Commits on Aug 9, 2023

  1. Add global settings for "UseArticulations". 

    Changing the setting will cause all affected assets to reprocess.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn
    mbalfour-amzn committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    1f42cdc View commit details
    Browse the repository at this point in the history

  2. Enable support for dae and obj files when the ROS2 Gem is enabled. 

    Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn
    mbalfour-amzn committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ccb1070 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.cpp 

    Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn @lemonade-dm
    mbalfour-amzn and lemonade-dm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    60fdb1d View commit details
    Browse the repository at this point in the history

  2. Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h 

    Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn @lemonade-dm
    mbalfour-amzn and lemonade-dm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0786504 View commit details
    Browse the repository at this point in the history

  3. Update Gems/ROS2/Registry/sceneassetimporter.setreg 

    Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn @lemonade-dm
    mbalfour-amzn and lemonade-dm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e68cfc8 View commit details
    Browse the repository at this point in the history

  4. Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.cpp 

    Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn @lemonade-dm
    mbalfour-amzn and lemonade-dm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1e0be5a View commit details
    Browse the repository at this point in the history

  5. PR feedback. 

    Make LoadSettings take in a settings registry.
Move the AP settings into the scene setreg file for better settings locality.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn
    mbalfour-amzn committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e46714f View commit details
    Browse the repository at this point in the history

  6. Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h 

    Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn @lemonade-dm
    mbalfour-amzn and lemonade-dm committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    928052e View commit details
    Browse the repository at this point in the history

  7. PR feedback - make global settings registry the default. 

    Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
    @mbalfour-amzn
    mbalfour-amzn committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    549f501 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'o3de:development' into mbalfour/asset_builder_global_se… 

    …ttings
    @mbalfour-amzn
    mbalfour-amzn committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4a4a62c View commit details
    Browse the repository at this point in the history