Added docs for Bloom Component #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chanmosq <75444793+chanmosq@users.noreply.github.com>
chanmosq
added
the
status/needs-edit
Signed-off-by: chanmosq <75444793+chanmosq@users.noreply.github.com>
28 tasks
FiniteStateGit
requested changes
Jan 20, 2022
Signed-off-by: chanmosq <75444793+chanmosq@users.noreply.github.com>
FiniteStateGit
approved these changes
Jan 20, 2022
willihay
requested changes
Jan 21, 2022
| | - | - | - | - | | ||
| | **Enable Bloom** | If enabled, activates the bloom effect. | Boolean | `Enabled` | | ||
| | **Overrides** | If enabled, all Bloom component properties will be set to the values specified in the **Overrides** property group. | Boolean | `Enabled` | |
There was a problem hiding this comment.
I don't get it. Why are overrides on by default? Seems like a strange UI/UX choice to me.
There was a problem hiding this comment.
Also, it doesn't seem to be a simple value override to me. Looking at Intensity, for example: The normal range is 0 to 10000. (Anything above 2 produces absurd-looking results, but whatever.) If I set Intensity to 2.5 and the Intensity Override factor to 0.0, you'd think that I'd see a difference when I toggle Enable Override, but I don't. Also, the scale of the Intensity Override is only 0 to 1. If it were a simple value replacement override, the scale should be the same.
There was a problem hiding this comment.
An open issue related to the intensity slider: o3de/o3de#5993.
Signed-off-by: chanmosq <75444793+chanmosq@users.noreply.github.com>
willihay
approved these changes
Jan 25, 2022
chanmosq
removed
the
status/needs-edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Submission Checklist: