Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows offline installer instructions #2445

Merged
merged 2 commits into from Jun 30, 2023
Merged

Windows offline installer instructions #2445

merged 2 commits into from Jun 30, 2023

Conversation

amzn-changml
Copy link
Contributor

Change summary

Adds a short note in the Windows installer instructions to create an offline installer layout.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

@amzn-changml
Add the offline installer instructions for Windows
b94a255 
Signed-off-by: Mike Chang <changml@amazon.com>
@amzn-changml amzn-changml requested review from a team as code owners June 30, 2023 17:13
@amzn-changml amzn-changml changed the base branch from development to main June 30, 2023 17:13
@amzn-changml
Change wording
9ea158b 
Signed-off-by: Mike Chang <changml@amazon.com>
@amzn-changml amzn-changml mentioned this pull request Jun 30, 2023
Open
AMZN-alexpete
AMZN-alexpete approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@AMZN-alexpete AMZN-alexpete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

tonybalandiuk
tonybalandiuk approved these changes Jun 30, 2023
View reviewed changes
Copy link

@tonybalandiuk tonybalandiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions are clear for creating an offline installer.

@amzn-changml amzn-changml merged commit f5dad19 into o3de:main Jun 30, 2023
6 checks passed
@amzn-changml amzn-changml deleted the windows-offline-installer branch June 30, 2023 18:52
@amzn-changml amzn-changml mentioned this pull request Oct 2, 2023
Closed
jhanca-robotecai pushed a commit that referenced this pull request Dec 22, 2023
@amzn-changml @jhanca-robotecai
Windows offline installer instructions (#2445)
a30c1ad 
* Add the offline installer instructions for Windows

Signed-off-by: Mike Chang <changml@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMZN-alexpete AMZN-alexpete AMZN-alexpete approved these changes

@tonybalandiuk tonybalandiuk tonybalandiuk approved these changes

@nick-l-o3de nick-l-o3de Awaiting requested review from nick-l-o3de nick-l-o3de was automatically assigned from o3de/reviewers

@Naomi-Wash Naomi-Wash Awaiting requested review from Naomi-Wash Naomi-Wash was automatically assigned from o3de/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amzn-changml @AMZN-alexpete @tonybalandiuk