Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Material Editor page in Atom Docs #406

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Add Material Editor page in Atom Docs #406

merged 4 commits into from
Apr 15, 2021

Conversation

chanmosq
Copy link
Contributor

@chanmosq chanmosq commented Apr 6, 2021

This page provides an introduction to the Material Editor application.

Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
Comment on lines 216 to 217
- **Skybox Image Asset**: Assign a diffuse lighting cubemap.
- **Skybox Image Asset (Alt)**: Assign an alternative diffuse lighting cubemap.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 216 and 217 may need clarification. I think SkyBox Image Asset is simply the image that is displayed, and it doesn't contribute to lighting. I am not sure what Skybox Image Asset (Alt) actually does. It seems to always use the diffuse lighting cubemap... maybe it's used for LoD or debugging scenarios?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Skybox Image Asset and Skybox Image Asset (Alt) hold diffuse lighting cubemap. The user can toggle Enable Alternate Skybox from the General settings, in order to use the Skybox Image Asset (Alt).
The purpose of this is that artists often use both a high-detailed cubemap, and a low-detailed diffuse version as an alternative option. The alternative allows them to view their material with a less distracting background, while still under the same lighting conditions.

content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
The following are properties you can configure for the selected lighting preset.

- **Auto-select**: When enabled, this preset can be automatically selected at start-up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when it's enabled? What does selecting it at start-up do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-select property is being removed, so I will remove that here. Previously, it would load the preset when the Material Editor first launches.

content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@chanmosq chanmosq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP applying code review. I addressed only some of the comments so far.

content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
content/docs/atom-guide/materials/material-editor.md Outdated Show resolved Hide resolved
Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
@chanmosq chanmosq requested a review from carrcain April 15, 2021 18:55
@micronAMZN micronAMZN merged commit 233d271 into o3de:main Apr 15, 2021
@chanmosq chanmosq self-assigned this Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants