Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiating and Deleting a prefab requires the user to save the level twice #11756

Closed
srikappa-amzn opened this issue Sep 2, 2022 · 3 comments · Fixed by #12061
Closed
Assignees
Labels
feature/prefabs This item is related to the prefab system kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/content Categorizes an issue or PR as relevant to SIG Content.
Milestone

Comments

@srikappa-amzn
Copy link
Contributor

Describe the bug
Instantiating and Deleting a prefab requires the user to save the level twice

Steps to reproduce
Steps to reproduce the behavior:

  1. Open any level
  2. Instantiate a new prefab
  3. Hit Ctrl+S or file->save. Notice that the level is still marked dirty
  4. Hit Ctrl+S again. Notice that it is saved now.
  5. Repeat the same steps but with deleting the prefab instead of instantiating it.

Expected behavior
Level gets saved correctly on the first save.

Actual behavior
Level is still marked dirty after hitting ctrl+s for the first time.

Found in Branch
stabilization/2210 and development

@srikappa-amzn srikappa-amzn added kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/content Categorizes an issue or PR as relevant to SIG Content. feature/prefabs This item is related to the prefab system priority/major Major priority. Work that should be handled after all blocking and critical work is done. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 2, 2022
@jckand jckand added this to the Release/2210 milestone Sep 7, 2022
@jckand
Copy link
Contributor

jckand commented Sep 7, 2022

If fix ends up to be too risky for stabilization, we can add a release note for this issue instead.

@forkercat
Copy link
Contributor

forkercat commented Sep 13, 2022

Did some closer look. Similar to #11452 (multiple Ctrl+S for create-entity).

For instantiate-prefab workflow, I suggest putting (1) to stabilization and then merge back to development. (2) can be added to development later.

  1. Add prefab undo cache update (I verified this should be enough fix the issue)
  2. Add the missing parent DOM update (this is needed as we're removing prefab undo cache and depend on DOM in template)

For delete workflow, the workflow was reworked in development (#11699). I verified the issue no longer occurs in development now. For the old workflow in stabilization, I don't think there is a temp fix we can go ahead at this time because it does not know parent entity info during deletion, which is unlike the new workflow.

  1. We can either merge the new workflow to stabilization. Or
  2. Keep unchanged for this release.

@forkercat
Copy link
Contributor

[ Update 9/22 ]

  1. For instantiate-prefab, verified fixed in both development and stabilization.
  2. For delete-prefab, verified fixed in development after the rework commit for deletion. But that was before stab cut-off and it is a bit risky to cherry-pick it into stab at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/prefabs This item is related to the prefab system kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/content Categorizes an issue or PR as relevant to SIG Content.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants