Add operation name in undo/redo console log #15146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
forkercat
added
feature/editor
forkercat
commented
Mar 16, 2023
| @@ -335,7 +342,6 @@ void CUndoManager::Redo(int numSteps) | |||
| { | |||
| GetIEditor()->UpdateViews(eUpdateObjects); | |||
| } | |||
| GetIEditor()->GetLogFile()->FormatLine("Redo (Undo:%d,Redo:%d)", m_undoStack.size(), m_redoStack.size()); | |||
| GetIEditor()->GetObjectManager()->InvalidateVisibleList(); | |||
There was a problem hiding this comment.
Move the log to the above while loop. If numSteps is N (>1), it should output for N times.
Also, by putting it there, no assertion is needed for checking the stack size before using node in it.
srikappa-amzn
approved these changes
Mar 16, 2023
gadams3
approved these changes
Mar 16, 2023
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the operation names in undo/redo logs in console.
Before:
After:
How was this PR tested?
Tested in editor