No cross-prefab reparenting in editor transform component #15889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
forkercat
requested review from
lsemp3d,
srikappa-amzn,
michabr,
dtamkin1 and
alexmontAmazon
srikappa-amzn
approved these changes
May 9, 2023
Code/Framework/AzToolsFramework/AzToolsFramework/UI/Outliner/EntityOutlinerListModel.cpp
Outdated
Show resolved
Hide resolved
Code/Framework/AzToolsFramework/AzToolsFramework/ToolsComponents/TransformComponent.cpp
Outdated
Show resolved
Hide resolved
AMZN-daimini
approved these changes
May 9, 2023
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15260 issue (previous fix did not fix all cases)
This PR blocks users from parenting an entity or a nested prefab to an entity owned by a different prefab in TransformComponent's parent field.
Previously, there was a PR #14411 blocking this, but it was only for drag-and-drop in Entity Outliner.
Change List:
InstanceEntityMapperInterfacedependency)How was this PR tested?
ReparentInTransform.mp4