Add missing getters to PhysX/ArticulationJointBus. #16008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpelka
force-pushed
the
mp/adjust_Articulations
branch
from
a6e4469
to
c6e33c6
Compare
|
LGTM. Nice @michalpelka ! |
lgleim
approved these changes
Jun 5, 2023
lemonade-dm
approved these changes
Jun 5, 2023
Modify `ArticulationLinkComponent` to implemented extend ArticulationJointBus. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
force-pushed
the
mp/adjust_Articulations
branch
from
c6e33c6
to
4648d06
Compare
michalpelka
added a commit
to RobotecAI/o3de
that referenced
this pull request
Jul 13, 2023
Modify `ArticulationLinkComponent` to implemented extend ArticulationJointBus. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
ArticulationLinkComponentto implement extend ArticulationJointBus.What does this PR do?
This PR is adding missing getters to
ArticulationJointBus:GetJointPositionGetJointVelocityHow was this PR tested?
Manual testing implementing, new features in ROS2 Gem.