Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Archive Gem build on MacOS #16161

Merged

Conversation

lemonade-dm
Copy link
Contributor

Several integer values needed explicit static cast into smaller types

How was this PR tested?

Built the Archive.Editor.Tests target successfully and verified that the Archive Unit Test also complete successfully as well.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Copy link
Contributor

@spham-amzn spham-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says 'This CODEOWNERS file is valid. '

@lemonade-dm
Copy link
Contributor Author

It says 'This CODEOWNERS file is valid. '

It certainly is.

@lemonade-dm lemonade-dm merged commit b39157b into o3de:development Jun 14, 2023
3 checks passed
@lemonade-dm lemonade-dm deleted the archive-gem-macos-fix branch June 14, 2023 02:50
@spham-amzn spham-amzn added the sig/platform Categorizes an issue or PR as relevant to SIG Platform. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/platform Categorizes an issue or PR as relevant to SIG Platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants