[Cherry-Pick from development] Wwise SDK fix and Compression gem related fix #16988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
The DecompressionRegistrarEntry class replicates the logic of the [FullFileDecompressor](https://github.com/o3de/o3de/blob/development/Code/Framework/AzCore/AzCore/IO/Streamer/FullFileDecompressor.h#L47-L56), but instead uses the AZ Task System instead of the AZ Job System. Because the DecompressionRegistrarEntry class hasn't been tested and is unneeded for decompression of compressed files within a pak file, it shouldn't be used. fixes o3de#16954 Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
The Compression Gem is not integral to using O3DE out of the box. Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
lemonade-dm
approved these changes
Oct 30, 2023
gadams3
approved these changes
Oct 30, 2023
AMZN-alexpete
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cherry pick fixes from
How was this PR tested?
These changes were tested with release builds on PC in development, verifying Wwise can compile with VS 2022 and latest Wwise SDK at the time, default engine asset bundles do not issue warnings/errors about missing assets and release builds no longer freeze on start up when loading shaders.