Quality of life improvements for the project export script #17160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he export scripts Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
tkothadev
reviewed
Dec 1, 2023
tkothadev
reviewed
Dec 1, 2023
tkothadev
reviewed
Dec 1, 2023
tkothadev
reviewed
Dec 1, 2023
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Co-authored-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
AMZN-alexpete
approved these changes
Dec 1, 2023
tkothadev
approved these changes
Dec 1, 2023
spham-amzn
deleted the
spham_amzn/update_export_script_command_settings
branch
spham-amzn
added a commit
to aws-lumberyard-dev/o3de
that referenced
this pull request
Dec 2, 2023
* Incorporate command_settings to allow setting default arguments for the export scripts * renamed text and comments from android to project export Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
AMZN-alexpete
pushed a commit
to aws-lumberyard-dev/o3de
that referenced
this pull request
Dec 14, 2023
* Incorporate command_settings to allow setting default arguments for the export scripts * renamed text and comments from android to project export Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> # Conflicts: # scripts/o3de/ExportScripts/export_source_built_project.py # scripts/o3de/o3de/export_project.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Incorporate command_settings to allow setting default arguments for the export scripts
How was this PR tested?
ad-hoc testing