Cherry-pick PR #17568 fromdev to point-release/23103 #17817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrcolin
added
sig/content
AMZN-daimini
approved these changes
Apr 23, 2024
lemonade-dm
approved these changes
Apr 24, 2024
|
|
||
| // specialized version of BuildFailure, for when the failure type is a MoveFailure, the string will be in m_reason | ||
| template<> | ||
| void BuildFailure(MoveFailure& failure, AZStd::vector<AZStd::string>& lines) |
There was a problem hiding this comment.
repeat: the failure parameter should be const MoveFailure&
Suggested change
| void BuildFailure(MoveFailure& failure, AZStd::vector<AZStd::string>& lines) | |
| void BuildFailure(const MoveFailure& failure, AZStd::vector<AZStd::string>& lines) |
Code/Tools/AssetProcessor/native/AssetManager/AssetRequestHandler.cpp
Outdated
Show resolved
Hide resolved
|
Will do a local compile test of those changes, then commit. I'll prepare a cherrypick for the const back to development. |
Fixes the bug causing asset browser to be unable to delete/move/etc. (o3de#17568) * Fixes o3de#15671 - [Bug Report] Asset Browser cannot delete asset * Adds missing functionality from the Linux ProcessWatcher to indicate the difference between a different problem launching program, and the program not being found. * Fixes the workflow of the Move/Delete/Rename operations in the Asset Browser to properly return the appropriate error when Source Control is not properly configured. * Adds a toggle for source control notification in AP, so that if you toggle the Editor to not use Source Control, the AP will not either. * Uses the same setting in AP as the Editor, to determine whether Source Control should be used or not, and sets it to false by default, just like the Editor. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
nick-l-o3de
force-pushed
the
pointrelease-cherrypick-pr17568
branch
from
0a2bbd5
to
cbfd01a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug causing asset browser to be unable to delete/move/etc. (#17568)