Fixes crash when full refreshing AssetProcessor #17869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
nick-l-o3de
requested review from
lemonade-dm,
jjjoness and
a team
and removed request for
a team
spham-amzn
reviewed
May 2, 2024
Code/Framework/AzToolsFramework/AzToolsFramework/AssetBrowser/AssetBrowserComponent.cpp
Outdated
Show resolved
Hide resolved
spham-amzn
approved these changes
May 2, 2024
lsemp3d
approved these changes
May 3, 2024
…AssetBrowserComponent.cpp Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
Merged
nick-l-o3de
added a commit
to nick-l-o3de/o3de
that referenced
this pull request
May 3, 2024
* Fixes crash when full refreshing AssetProcessor Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> * Update Code/Framework/AzToolsFramework/AzToolsFramework/AssetBrowser/AssetBrowserComponent.cpp Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> --------- Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
nick-l-o3de
added a commit
that referenced
this pull request
May 14, 2024
* Fixes crash when full refreshing AssetProcessor Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
nick-l-o3de
added a commit
to nick-l-o3de/o3de
that referenced
this pull request
May 16, 2024
) * Fixes crash when full refreshing AssetProcessor Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
nick-l-o3de
added a commit
to nick-l-o3de/o3de
that referenced
this pull request
May 19, 2024
) * Fixes crash when full refreshing AssetProcessor Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
nick-l-o3de
added a commit
that referenced
this pull request
May 19, 2024
… into dev in time (#17927) * Cherrypick pr fixes from pointrelease to development (#17839) Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> * Fixes a flaky test and possible actual crash (#17826) (#17838) Cherry-pick of PR #17826 to development branch from point release commit 458541f It turns out that previewing a FBX or other scene in the asset browser causes the scene to be loaded and instantiated (ie, prefab processor runs) in an async thread. But that thread sets the name of the container Entity and causes the entity system to send entity name changes from that async thread, even though the entity is temp and inactive. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> * Fixes crash when full refreshing AssetProcessor (#17869) (#17874) * Fixes crash when full refreshing AssetProcessor Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> --------- Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes crash when full refreshing AssetProcessor
Also fixes a crash when deleting elements out of the file system
Also fixes a crash when clicking on thumbnails while they are generating.
How was this PR tested?
All three of the cases above were easy to repro 100%
Please describe any testing performed.
Testing all three of the above cases to ensure no crash anymore.
Testing duplicating/adding new script canvas assets to ensure they appear.
Deleting assets and ensuring they disappear
Clicking around in the AB while icons are generating
Doing the same in "list view" / search result mode.