Fix Vulkan issues with VK_ERROR_OUT_OF_DATE caused by the swapchain not being updated on a resize #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot being updated on a resize - Updated the RenderViewportWidget::event method to call 'SendWindowResizeEvent' on specific events - Moved the onResize to one of the events in RenderViewportWidget::event Signed-off-by: Steve Pham <spham@amazon.com>
NicholasVanSickle
approved these changes
Oct 15, 2021
| switch (event->type()) | ||
| { | ||
| case QEvent::ScreenChangeInternal: | ||
| case QEvent::UpdateLater: |
There was a problem hiding this comment.
Is this needed? I'm not sure what would be queueing a render here, but it also can't hurt to make sure the swap chain is valid if we do.
There was a problem hiding this comment.
Current Vulkan swapchain creation doesn't support recreation if changes in surface is detected. The only chance is through resize event, where the surface and swapchain are created from scratch, same as in initialization.
There 2 more events are found to change the surface as well. So we need to call resize, as this is currently the only way.
I am adding swapchain recreation now. This change can be a workaround to avoid crashes for Material Editor and UI Editor.
moudgils
approved these changes
Oct 15, 2021
jiaweig-amzn
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux using the MaterialEditor, it was observed that at least
ScreenChangeInternalandUpdateLaterneeded the swapchain to be recreated. Will test on WindowsSigned-off-by: Steve Pham spham@amazon.com