[LYN-7463] Fix insert streaming request failure #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st would start before the streamer request could be cleared Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
Fix test timeout which was way too long. Reduce test iterations to keep test time safely under 5 seconds. Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
|
This is being targeted for o3de:development |
|
Might also include sig-core since they are in charge of the AZ::IO::IStreamer |
jackalbe
approved these changes
Nov 12, 2021
…mer request first Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
mbalfour-amzn
approved these changes
Nov 15, 2021
It probably should go into stabilization, if I can get it in today |
lemonade-dm
approved these changes
Nov 15, 2021
AMZN-stankowi
approved these changes
Nov 15, 2021
amzn-mike
added a commit
to aws-lumberyard-dev/o3de
that referenced
this pull request
Nov 15, 2021
* Fix race condition where asset would finish loading and another request would start before the streamer request could be cleared Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> * Re-enable disabled test which was failing for the same reason. Fix test timeout which was way too long. Reduce test iterations to keep test time safely under 5 seconds. Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> * Instead of using a mutex, re-order the statements to remove the streamer request first Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> (cherry picked from commit 0cea59d) Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
AMZN-stankowi
pushed a commit
that referenced
this pull request
Nov 15, 2021
…5622) * Fix race condition where asset would finish loading and another request would start before the streamer request could be cleared Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> * Re-enable disabled test which was failing for the same reason. Fix test timeout which was way too long. Reduce test iterations to keep test time safely under 5 seconds. Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> * Instead of using a mutex, re-order the statements to remove the streamer request first Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> (cherry picked from commit 0cea59d) Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
AlexOteiza
pushed a commit
to aws-lumberyard-dev/o3de
that referenced
this pull request
Nov 17, 2021
* Fix race condition where asset would finish loading and another request would start before the streamer request could be cleared Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> * Re-enable disabled test which was failing for the same reason. Fix test timeout which was way too long. Reduce test iterations to keep test time safely under 5 seconds. Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com> * Instead of using a mutex, re-order the statements to remove the streamer request first Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a rare race condition where an asset would fully unload and be requested to start loading again before the previous streamer request could be removed.
Re-enabled a disabled test that had the same failure cause
Cleaned up the other test to run a bit quicker and fix its overly long timeout