Fixed problem with inputting numbers in sliders #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
cgalvan
reviewed
Jan 12, 2022
| updateSpinBox(); | ||
| updateSlider(); |
There was a problem hiding this comment.
I think this logic was for protecting that we don't double trigger updates, if the user inputs the value from either the slider or the input field, so it doesn't propagate twice. Is that still working as expected?
There was a problem hiding this comment.
Yes, I've tested this in most of the slider combos and it responds correctly.
…arInconsistent-o3de#5234 Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
AMZN-daimini
approved these changes
Jan 13, 2022
gadams3
approved these changes
Jan 13, 2022
…arInconsistent-o3de#5234 Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
…arInconsistent-o3de#5234 Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com>
jjjoness
deleted the
BeforeAndAfterInputtingValueInNumberBarInconsistent-#5234
branch
santorac
pushed a commit
to aws-lumberyard-dev/o3de
that referenced
this pull request
Jan 20, 2022
* Fixed problem with inputting numbers in sliders Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com> * Changes from PR Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com> * Missed removing pragma optimize Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com> Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com
