Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Manager | Refactor API to future-proof property assignment on construction. #9554

Merged
merged 19 commits into from May 16, 2022
Merged

Action Manager | Refactor API to future-proof property assignment on construction. #9554

merged 19 commits into from May 16, 2022

Commits on May 14, 2022

  1. Introduce corresponding bus to the ActionManagerInterface, and the pi… 

    …ping to reflect it to BehaviorContext.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    03f0669 View commit details
    Browse the repository at this point in the history

  2. Undo preliminary setup work to reflect the bus from the AzToolsFramew… 

    …ork module

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    e3ee6f5 View commit details
    Browse the repository at this point in the history

  3. Introduce classes to the EditorPythonBindings to expose ActionManager… 

    … functions to Python via a bus.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    8e7442d View commit details
    Browse the repository at this point in the history

  4. Remove bus connection calls from ActionManager. 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    ea277d3 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary include 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    5471261 View commit details
    Browse the repository at this point in the history

  6. Undo unnecessary changes 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    fee6d3b View commit details
    Browse the repository at this point in the history

  7. Add comments and streamline ActionManagerInterface access in PythonEd… 

    …itorActionHandler

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    9c10c28 View commit details
    Browse the repository at this point in the history

  8. Implement operator= for PythonEditorAction, add extra checks in case … 

    …of nullptr handler.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    aa88e2e View commit details
    Browse the repository at this point in the history

  9. Fix includes to skip Source folder 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    7dcf3db View commit details
    Browse the repository at this point in the history

  10. Fix PythonEditorAction operators. 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    d71fc61 View commit details
    Browse the repository at this point in the history

  11. Move new classes under namespace EditorPythonBindings 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    a506923 View commit details
    Browse the repository at this point in the history

  12. Change registration function signatures to support data structs inste… 

    …ad of all properties explicitly. This should make the API easier to extend and more readable, albeit more verbose.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    6e1b859 View commit details
    Browse the repository at this point in the history

  13. Fix tests to comply to the new API 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    261df78 View commit details
    Browse the repository at this point in the history

  14. Convert Python Bus and handlers to the properties structs 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    9a7218b View commit details
    Browse the repository at this point in the history

  15. Fixes to address class name changes in the BehaviorContext, fix inclu… 

    …des to work on Test submodule of EditorPythonBindings

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    cf1821a View commit details
    Browse the repository at this point in the history

  16. Restore mutable modifier on lambda after rebase 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    ca67841 View commit details
    Browse the repository at this point in the history

  17. Complete struct definition to allow reflection to Python 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    5b77203 View commit details
    Browse the repository at this point in the history

  18. Complete struct definition to allow reflection to Python 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    d2a19b8 View commit details
    Browse the repository at this point in the history

  19. Fix after property rename 

    Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
    @AMZN-daimini
    AMZN-daimini committed May 14, 2022
    Copy the full SHA
    13d7934 View commit details
    Browse the repository at this point in the history