Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Sky Atmosphere #9649
Initial Sky Atmosphere #9649
Changes from 38 commits
e1810e9
e63b51a
77be766
585af86
ce7c782
55f4d1e
bc88271
4f96459
191935d
7442785
0513aaf
a5cb059
fb5ffa9
e2ff7d6
5cbb3e0
4135d06
276a88c
8df7a75
56a8c2b
60d66a4
2870689
a9fe70d
412fadf
817da6d
493e22d
c55da3a
990be2d
cca1308
0881a2f
3118286
a7b69c5
60b16ca
1d7a703
54e58ad
2ffe8f4
5dafe09
7833b5e
ab767cb
dc214ee
183eee8
963835d
fdd4e0e
19e4689
b08fc97
047086f
3e0b454
35ef904
a4c0808
d642aee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be in its own Gem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can easily be moved to a gem, but I thought that if it would be eventually replacing the existing physical sky implementation then perhaps it makes sense to put in the same place.