Fix string-valued launch argument substitution #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a launch file that declares an argument meant to be used as a string,
in this example an IP address.
Performing the substitution as above inside the opaque function context results
in an
SyntaxError
being thrown since the given literal value10.0.30.112
--as seen by
ast.literal_eval
-- cannot be interpreted as valid Python.My suggested fix is simply catching this exception and returning any such
"invalid" inputs as strings.
It might be worth noting that one can bodge a fix on the user side as follows:
Note the additional quotes to force interpretation as a Python string.
P.S. Thank you for making this wonderful library. With it, I no longer feel existential
dread when faced with launching off a few ROS 2 nodes...