Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

totems: TotemFrame is parented to PlayerFrame #300

Merged
merged 1 commit into from
Sep 17, 2016
Merged

totems: TotemFrame is parented to PlayerFrame #300

merged 1 commit into from
Sep 17, 2016

Conversation

p3lim
Copy link
Member

@p3lim p3lim commented Sep 17, 2016

It will be hidden with oUF:DisableBlizzard()

Mentioned here: #283 (comment)

@p3lim
totems: TotemFrame is parented to PlayerFrame
aa7b6f3 
It will be hidden with oUF:DisableBlizzard()
@p3lim p3lim added the element label Sep 17, 2016
@p3lim p3lim added this to the 1.7.0 milestone Sep 17, 2016
@p3lim p3lim self-assigned this Sep 17, 2016
@ls- ls- merged commit 555545b into master Sep 17, 2016
@p3lim p3lim deleted the fix-totems-1 branch September 17, 2016 23:45
@p3lim
Copy link
Member Author

p3lim commented Sep 17, 2016

Was not sure if I wanted to kill the registering/unregistering of the TotemFrame events or not.

@ls-
Copy link
Member

ls- commented Sep 17, 2016 •
edited
Loading

It's fine as it's now, better safe than sorry...

@p3lim p3lim modified the milestones: 1.7.0, 1.6.10 Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ls- ls- ls- approved these changes

Assignees

@p3lim p3lim

Labels
element
Projects
None yet
Milestone
1.6.10
Development

Successfully merging this pull request may close these issues.
2 participants
@p3lim @ls-