stagger: Move colour update to its own function #359
Conversation
ls-
changed the title
elements/stagger.lua
Outdated
| element:SetMinMaxValues(0, max) | ||
| element:SetValue(cur) | ||
|
|
||
| --[[ Override: Stagger:UpdateColor(unit, perc) |
There was a problem hiding this comment.
yeah, forgot to remove it 😁🔫
elements/stagger.lua
Outdated
| element:SetValue(cur) | ||
|
|
||
| --[[ Override: Stagger:UpdateColor(unit, perc) | ||
| Used to completely override the internal function for updating the widgets' colors. |
There was a problem hiding this comment.
widget's instead of widgets' - we only have one
There was a problem hiding this comment.
Copypaste typo o_O
Copied it from health element, it says widgets' there...
elements/stagger.lua
Outdated
| Used to completely override the internal function for updating the widgets' colors. | ||
|
|
||
| * self - the Stagger element | ||
| * perc - the percentage of staggered damage (number) |
There was a problem hiding this comment.
Maybe add that it is relative to the player's maximum health.
There was a problem hiding this comment.
And maybe add value range
There was a problem hiding this comment.
Why though? It can't be relative to anything else, and it's a percentage, it's 0-1, always...
There was a problem hiding this comment.
It can be relative to what matters to whoever overrides UpdateColor. Also not all ppl think of percentages as values between 0-1. Actually perc is only used by UpdateColor, why not pass stagger and max health to it and calc perc in UpdateColor?
No description provided.