Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legion tags #265

Merged
merged 5 commits into from Sep 10, 2016
Merged

Legion tags #265

merged 5 commits into from Sep 10, 2016

Conversation

p3lim
Copy link
Member

@p3lim p3lim commented May 31, 2016

This PR contains additions/deprecations for the tags element for Legion.

These commits are compatible with both live and beta clients.

@p3lim p3lim mentioned this pull request May 31, 2016
@ls-
Copy link
Member

ls- commented Jul 13, 2016

While I was merging all PRs today, found one issue w/ this commit, more like a typo. It doesn't break anything. I dunno why I'm even writing this comment 😆

Soulshards are mentioned few times, but entry at line 423 isn't needed.

@p3lim
Copy link
Member Author

p3lim commented Jul 13, 2016

@ls- I'm gonna let that one slide until the post-patch cleanup.

Edit: rebased the branch.

@p3lim
Copy link
Member Author

p3lim commented Jul 29, 2016

Removed the compatibility code since 7.0 is already out.

@p3lim p3lim mentioned this pull request Jul 29, 2016
doadin pushed a commit to doadin/Elvui that referenced this pull request Aug 6, 2016
@haste haste merged commit 4e59b84 into oUF-wow:master Sep 10, 2016
@p3lim p3lim deleted the legion-tags branch September 11, 2016 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants