Wrap long lines nicely #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didib
force-pushed
the
wrap-long-lines-nicely
branch
from
89d5a8a
to
c55453b
Compare
|
Did this in the context of [1], but asked Nikolai to open a separate bug. I was annoyed by the output for years. Better late than never, I guess/hope. |
didib
force-pushed
the
wrap-long-lines-nicely
branch
from
c55453b
to
b11fa1d
Compare
|
Rebased |
didib
force-pushed
the
wrap-long-lines-nicely
branch
from
b11fa1d
to
c3c2d0d
Compare
|
Updated test_note to include a long URL. This should fail. Will then fix with a next update. |
didib
force-pushed
the
wrap-long-lines-nicely
branch
5 times, most recently
from
9361492
to
6339e0e
Compare
If dialog.note is passed long lines of text, it prepends some whitespace to each line to make output "nice", but does not try to break it, thus letting it wrap "normally" which looks ugly. Instead, break lines according to terminal width and prepend the same whitespace to each part. Change-Id: I4706323a95103eff3257507dd1bd0fdbaa59cd74 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
wrap-long-lines-nicely
branch
from
6339e0e
to
722a7a8
Compare
Add a plugin to output an arbitrary note. Useful for testing a recent patch to wrap note texts. Include a long URL in the note, and verify that it's output as-is, unwrapped. Change-Id: Id98433880c7bdf1cea3cfc80cc1cbbe59715fecf Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
wrap-long-lines-nicely
branch
from
722a7a8
to
98498d7
Compare
|
Tested engine-setup on a wide (190 column) terminal and it looks almost the same. Tested it on a 80-column terminal and I think it's an improvement, even if not perfect - we might want to further patch setup code. Merging, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.