github: Build from the pushed commit #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not merge/rebase, so that the git hash in the generated RPM's names matches the hash of the commit we build from. By default, the checkout action merges with HEAD, generating an ad-hoc hash that's discarded after the build and can't be found anywhere, making it very hard to find out which commit was used to build a particular RPM. See also: https://github.com/marketplace/actions/checkout?version=v2.4.2#checkout-pull-request-head-commit-instead-of-merge-commit https://lists.ovirt.org/archives/list/devel@ovirt.org/thread/7SEFKOASOATTMO2NK2SBWMOV4CV6LZOS/ Change-Id: Idf4dad88c028f1664b55314a34a9f798c9b1a23d Signed-off-by: Yedidyah Bar David <didi@redhat.com>
This was referenced Jul 7, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge/rebase, so that the git hash in the generated RPM's names
matches the hash of the commit we build from. By default, the checkout
action merges with HEAD, generating an ad-hoc hash that's discarded
after the build and can't be found anywhere, making it very hard to find
out which commit was used to build a particular RPM.
See also:
https://github.com/marketplace/actions/checkout?version=v2.4.2#checkout-pull-request-head-commit-instead-of-merge-commit
https://lists.ovirt.org/archives/list/devel@ovirt.org/thread/7SEFKOASOATTMO2NK2SBWMOV4CV6LZOS/
Change-Id: Idf4dad88c028f1664b55314a34a9f798c9b1a23d
Signed-off-by: Yedidyah Bar David didi@redhat.com