This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe running
rm -rf
here is safe.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe it is safe.
But if you do thi sin the
pretrans
of this package, won't it remove the directory even if theovirt-ansible-roles
package isn't updated? That would result in missing files in that package. Shouldn't thispretrans
be in theovirt-ansible-roles
RPM itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe %pretrans will be executed only if the package is part of a transaction. It should do nothing when the package itself is not updated. Stack Overflow seems to agree with me. https://stackoverflow.com/questions/22456217/rpm-scriptlet-ordering-for-install-remove-upgrade-using-yum
I would also expect this to be part of ovirt-ansible-roles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I've added it to
ovirt-ansible-roles
RPM, the script wasn't executed for some reason. But I will try it once more.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you are actually updating the package, the engine patch that is posted changes the dependencies in such a way that the ovirt-ansible-roles package will not be part of the transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the issue is that the
ovirt-ansible-roles
package requresovirt-ansible-cluster-upgrade
, but the only still it don't work:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both new installation and upgrade from 4.1.z work fine, then let's merge those changes on the each roles RPM, so we can execute RC build on Monday. And if needed we can improve later.
Thanks
Martin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compose is on tuesday, so we can decide on Monday how to proceed. We dont block the build.