New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete old standalone roles packages #115
Conversation
Before publishing collection RPM we need to make sure that all dependencies are already updated to use new collection package |
ovirt-ansible-collection.spec.in
Outdated
Release: @RPM_RELEASE@%{?release_suffix}%{?dist} | ||
Source0: http://resources.ovirt.org/pub/src/@PACKAGE_NAME@/@PACKAGE_NAME@-@PACKAGE_VERSION@.tar.gz | ||
License: ASL 2.0 and GPLv3+ | ||
Group: Virtualization/Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is here an extra tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, in vim everything looks aligned ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, please remove Group line at all, not meaningful anymore.
As far as I know, @arachmani added all necessary packages when migrating hosted-engine-setup to the collection. The requirements were added to the bindep.txt and spec file. |
Yes, but I'm talking about below:
Above requires need to be changed to ovirt-ansible-collection and this need to be synced with this Obsoletes patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
Use tabs in spec file to make it more readable Signed-off-by: Martin Perina <mperina@redhat.com>
Adds Obsoletes for all standalone roles packages which were already moved into oVirt Ansible Collection Signed-off-by: Martin Perina <mperina@redhat.com>
Group directive is not usefull for oVirt packages Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
5ef8829
to
5dde946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add Obsoletes directive to allow smooth upgrade from old standalone roles packages to the new collection package