Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete old standalone roles packages #115

Merged
merged 4 commits into from Oct 27, 2020

Conversation

mwperina
Copy link
Member

Add Obsoletes directive to allow smooth upgrade from old standalone roles packages to the new collection package

@mwperina
Copy link
Member Author

Before publishing collection RPM we need to make sure that all dependencies are already updated to use new collection package

@arachmani

Release: @RPM_RELEASE@%{?release_suffix}%{?dist}
Source0: http://resources.ovirt.org/pub/src/@PACKAGE_NAME@/@PACKAGE_NAME@-@PACKAGE_VERSION@.tar.gz
License: ASL 2.0 and GPLv3+
Group: Virtualization/Management
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is here an extra tab?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, in vim everything looks aligned ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, please remove Group line at all, not meaningful anymore.

@mnecas
Copy link
Member

mnecas commented Sep 11, 2020

As far as I know, @arachmani added all necessary packages when migrating hosted-engine-setup to the collection. The requirements were added to the bindep.txt and spec file.
(python3-netaddr, python3-jmespath, python3-passlib)

@mwperina
Copy link
Member Author

As far as I know, @arachmani added all necessary packages when migrating hosted-engine-setup to the collection. The requirements were added to the bindep.txt and spec file.
(python3-netaddr, python3-jmespath, python3-passlib)

Yes, but I'm talking about below:

  • ovirt-engine requires ovirt-ansible-roles
  • ovirt-engine-ui-extensions requires ovirt-ansible-cluster-upgrade
  • ovirt-hosted-engine-setup requires ovirt-ansible-engine-setup
  • ovirt-hosted-engine-setup requires ovirt-ansible-hosted-engine-setup
  • ovirt-engine-metrics requires ovirt-ansible-image-template
  • ovirt-engine-metrics requires ovirt-ansible-vm-infra

Above requires need to be changed to ovirt-ansible-collection and this need to be synced with this Obsoletes patch

@sandrobonazzola sandrobonazzola changed the title Obsolete old stanalone roles packages Obsolete old standalone roles packages Sep 17, 2020
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

Use tabs in spec file to make it more readable

Signed-off-by: Martin Perina <mperina@redhat.com>
Adds Obsoletes for all standalone roles packages which were already
moved into oVirt Ansible Collection

Signed-off-by: Martin Perina <mperina@redhat.com>
Group directive is not usefull for oVirt packages

Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit a475f30 into oVirt:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants