roles: hosted_engine_setup: remove duplicate tasks #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `hosted-engine --deploy`, "Sync on engine machine" and "Final clean" tasks run twice, once at the end of "Creating Target VM" stage and right after that in "Cleaning temporary resources" stage. This PR removes these tasks from "Creating Target VM" stage, therefore they will be executed only in the "Final clean" stage. Bug-Url: https://bugzilla.redhat.com/1977486 Signed-off-by: Asaf Rachmani <arachman@redhat.com>
|
OK for me. Did you verify that you manage to get local vm logs on both success and failure? |
|
Verified |
vjuranek
pushed a commit
to vjuranek/ovirt-ansible-collection
that referenced
this pull request
Jul 28, 2021
When using `hosted-engine --deploy`, "Sync on engine machine" and "Final clean" tasks run twice, once at the end of "Creating Target VM" stage and right after that in "Cleaning temporary resources" stage. This PR removes these tasks from "Creating Target VM" stage, therefore they will be executed only in the "Final clean" stage. Bug-Url: https://bugzilla.redhat.com/1977486 Signed-off-by: Asaf Rachmani <arachman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
hosted-engine --deploy, "Sync on engine machine" and"Final clean" tasks run twice, once at the end of "Creating Target VM" stage
and right after that in "Cleaning temporary resources" stage.
This PR removes these tasks from "Creating Target VM" stage,
therefore they will be executed only in the "Final clean" stage.
Bug-Url: https://bugzilla.redhat.com/1977486
Signed-off-by: Asaf Rachmani arachman@redhat.com